Reviewers: Vyacheslav Egorov,
Message:
The change to spaces-inl.h:254 was not required to make it compile, but I
added
anyway.
Description:
Fix Windows x64 build broken by r5299.
Please review this at http://codereview.chromium.org/3158019/show
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/spaces-inl.h
M src/spaces.cc
Index: src/spaces-inl.h
===================================================================
--- src/spaces-inl.h (revision 5299)
+++ src/spaces-inl.h (working copy)
@@ -243,15 +243,15 @@
bool Page::GetPageFlag(PageFlag flag) {
- return (flags_ & (1 << flag)) != 0;
+ return (flags_ & static_cast<intptr_t>(1 << flag)) != 0;
}
void Page::SetPageFlag(PageFlag flag, bool value) {
if (value) {
- flags_ |= (1 << flag);
+ flags_ |= static_cast<intptr_t>(1 << flag);
} else {
- flags_ &= ~(1 << flag);
+ flags_ &= ~static_cast<intptr_t>(1 << flag);
}
}
Index: src/spaces.cc
===================================================================
--- src/spaces.cc (revision 5299)
+++ src/spaces.cc (working copy)
@@ -390,7 +390,7 @@
}
Counters::memory_allocated.Decrement(static_cast<int>(length));
size_ -= static_cast<int>(length);
- if (executable == EXECUTABLE) size_executable_ -= length;
+ if (executable == EXECUTABLE) size_executable_ -=
static_cast<int>(length);
ASSERT(size_ >= 0);
}
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
