Revision: 5304
Author: mikhail.naga...@gmail.com
Date: Wed Aug 18 08:36:00 2010
Log: Fix issue 833: eliminate race condition in ProfilerEventsProcessor.
When under a load, the ProfilerEventsProcessor thread can start
(enter Run) after Stop has been called, thus resetting running_
data member back to 'true', and starting an infinite loop.
BUG=833
Review URL: http://codereview.chromium.org/3157022
http://code.google.com/p/v8/source/detail?r=5304
Modified:
/branches/bleeding_edge/src/cpu-profiler.cc
=======================================
--- /branches/bleeding_edge/src/cpu-profiler.cc Tue Aug 10 05:06:42 2010
+++ /branches/bleeding_edge/src/cpu-profiler.cc Wed Aug 18 08:36:00 2010
@@ -46,7 +46,7 @@
ProfilerEventsProcessor::ProfilerEventsProcessor(ProfileGenerator*
generator)
: generator_(generator),
- running_(false),
+ running_(true),
ticks_buffer_(sizeof(TickSampleEventRecord),
kTickSamplesBufferChunkSize,
kTickSamplesBufferChunksCount),
@@ -247,7 +247,6 @@
void ProfilerEventsProcessor::Run() {
unsigned dequeue_order = 0;
- running_ = true;
while (running_) {
// Process ticks until we have any.
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
