comments addressed.
http://codereview.chromium.org/3107027/diff/1/3 File src/arm/assembler-arm.h (right): http://codereview.chromium.org/3107027/diff/1/3#newcode131 src/arm/assembler-arm.h:131: On 2010/08/23 10:41:43, Erik Corry wrote:
We try to have two blank lines between functions and classes at the
top level,
so please reinstate the blank line here.
Done. http://codereview.chromium.org/3107027/diff/1/4 File src/arm/constants-arm.h (right): http://codereview.chromium.org/3107027/diff/1/4#newcode272 src/arm/constants-arm.h:272: inline int VFPNRegCode(bool sp) { return VFPGlueRegCode(sp, 16, 7); } On 2010/08/23 10:41:43, Erik Corry wrote:
Using bool in parameter lists makes the call sites unreadable. Please
redo with
an enum with kSinglePrecision and kDoublePrecision.
Done. http://codereview.chromium.org/3107027/diff/1/4#newcode351 src/arm/constants-arm.h:351: // bit specifier. Added curly brackets for the if statement, I am not sure what do you mean by strange. http://codereview.chromium.org/3107027/show -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev
