LGTM if you add
ASSERT((length > kMaxCachedArrayIndexLength) || (hash & String::kContainsCachedArrayIndexMask) == 0); into MakeCachedArrayIndex and rename it per Anton's suggestion into MakeArrayIndexHash. http://codereview.chromium.org/3295017/show -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev