Revision: 5496
Author: mikhail.naga...@gmail.com
Date: Mon Sep 20 05:25:45 2010
Log: Fix ProfileNodeFindOrAddChildForSameFunction test on Win32 debug.
Test was failing is due to a fact that MSVC in debug mode uses
separate instances for identical string literals.
tbr=sgje...@chromium.org
Review URL: http://codereview.chromium.org/3381013
http://code.google.com/p/v8/source/detail?r=5496
Modified:
/branches/bleeding_edge/test/cctest/test-profile-generator.cc
=======================================
--- /branches/bleeding_edge/test/cctest/test-profile-generator.cc Mon Sep
20 02:29:12 2010
+++ /branches/bleeding_edge/test/cctest/test-profile-generator.cc Mon Sep
20 05:25:45 2010
@@ -90,18 +90,20 @@
TEST(ProfileNodeFindOrAddChildForSameFunction) {
+ const char* empty = "";
+ const char* aaa = "aaa";
ProfileNode node(NULL, NULL);
- CodeEntry entry1(i::Logger::FUNCTION_TAG, "", "aaa", "", 0,
+ CodeEntry entry1(i::Logger::FUNCTION_TAG, empty, aaa, empty, 0,
TokenEnumerator::kNoSecurityToken);
ProfileNode* childNode1 = node.FindOrAddChild(&entry1);
CHECK_NE(NULL, childNode1);
CHECK_EQ(childNode1, node.FindOrAddChild(&entry1));
// The same function again.
- CodeEntry entry2(i::Logger::FUNCTION_TAG, "", "aaa", "", 0,
+ CodeEntry entry2(i::Logger::FUNCTION_TAG, empty, aaa, empty, 0,
TokenEnumerator::kNoSecurityToken);
CHECK_EQ(childNode1, node.FindOrAddChild(&entry2));
// Now with a different security token.
- CodeEntry entry3(i::Logger::FUNCTION_TAG, "", "aaa", "", 0,
+ CodeEntry entry3(i::Logger::FUNCTION_TAG, empty, aaa, empty, 0,
TokenEnumerator::kNoSecurityToken + 1);
CHECK_EQ(childNode1, node.FindOrAddChild(&entry3));
}
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
