Revision: 5668
Author: a...@chromium.org
Date: Wed Oct 20 01:52:46 2010
Log: Update x64 RecordWrite comment. When the offset is zero the index
should be an untagged 32-bit integer on x64. There are debug mode
asserts in the code that catch tagged integers so we get test
failures if we get it wrong.
Review URL: http://codereview.chromium.org/3928002
http://code.google.com/p/v8/source/detail?r=5668
Modified:
/branches/bleeding_edge/src/x64/macro-assembler-x64.h
=======================================
--- /branches/bleeding_edge/src/x64/macro-assembler-x64.h Thu Sep 30
04:48:03 2010
+++ /branches/bleeding_edge/src/x64/macro-assembler-x64.h Wed Oct 20
01:52:46 2010
@@ -101,9 +101,9 @@
// dirty. |object| is the object being stored into, |value| is the
// object being stored. If |offset| is zero, then the |scratch|
// register contains the array index into the elements array
- // represented as a Smi. All registers are clobbered by the
- // operation. RecordWrite filters out smis so it does not update the
- // write barrier if the value is a smi.
+ // represented as an untagged 32-bit integer. All registers are
+ // clobbered by the operation. RecordWrite filters out smis so it
+ // does not update the write barrier if the value is a smi.
void RecordWrite(Register object,
int offset,
Register value,
@@ -122,7 +122,7 @@
// The value is known to not be a smi.
// object is the object being stored into, value is the object being
stored.
// If offset is zero, then the scratch register contains the array index
into
- // the elements array represented as a Smi.
+ // the elements array represented as an untagged 32-bit integer.
// All registers are clobbered by the operation.
void RecordWriteNonSmi(Register object,
int offset,
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
