Almost LG. Sorry for being slow.
Thanks, Vitaly http://codereview.chromium.org/5107003/diff/9001/src/api.cc File src/api.cc (right): http://codereview.chromium.org/5107003/diff/9001/src/api.cc#newcode556 src/api.cc:556: #define MAKE_CREATE_HANDLE(Type) \ Ugh, I'm not a huge fan of explicit template instantiations. I think the approach like in http://codereview.chromium.org/5581006 should be simpler and less fragile. Could you please give it a try? (I verified it produces the right assembly code even though it looks less "compile time".) http://codereview.chromium.org/5107003/diff/9001/src/log.h File src/log.h (right): http://codereview.chromium.org/5107003/diff/9001/src/log.h#newcode91 src/log.h:91: #define LOG_FOR_ISOLATE(isolate, Call) ((void) 0) Doing this in two steps will most likely cause too many formatting changes to make lint happy. Is it too much work to be done in one step? http://codereview.chromium.org/5107003/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev
