Reviewers: Søren Gjesse,
Message:
Søren, I'm not sure you're the right person for this review. If not, can
you
please pass this on to the right person? Thanks.
This change is a small change to add names to threads so that they can be
identified by external tools when debugging v8 activity in a system. By
default
this code is disabled, and should not anyone that does not wish to enable
it.
This change has been tested with a release build with the debugthreadnames
option enabled and disabled.
I only added the option to SConstruct, but it should not break builds using
gyp
or other projects. The feature will just be disabled on those.
Description:
Added labelled thread names to help with some debugging activity. Right
now,
the only platform that it works on is linux (using the prctl API to set the
names of the threads). Other platforms are setup to build properly if the
flag is set, but their thread names are not currently set.
Please review this at http://codereview.chromium.org/6070009/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M SConstruct
M src/cpu-profiler.cc
M src/d8-debug.h
M src/d8.cc
M src/debug-agent.h
M src/debug.cc
M src/log.cc
M src/platform-freebsd.cc
M src/platform-linux.cc
M src/platform-macos.cc
M src/platform-nullos.cc
M src/platform-openbsd.cc
M src/platform-solaris.cc
M src/platform-win32.cc
M src/platform.h
M src/top.cc
M src/v8threads.cc
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
