http://codereview.chromium.org/6104004/diff/1/src/x64/full-codegen-x64.cc
File src/x64/full-codegen-x64.cc (right):

http://codereview.chromium.org/6104004/diff/1/src/x64/full-codegen-x64.cc#newcode1390
src/x64/full-codegen-x64.cc:1390: __
push(EmitSlotSearch(obj_proxy->var()->AsSlot(), rcx));
On 2011/01/06 13:12:22, Kevin Millikin wrote:
I know this is a duplication of the code on ia32, but I'd prefer to
have it
written in both places as:


Fixed all places here and on ia32.
MemOperand slot_operand = EmitSlotSearch(...);
__ push(slot_operand);

to be super careful about the side-effect of EmitSlotSearch (which may
emit
code).

http://codereview.chromium.org/6104004/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to