http://codereview.chromium.org/6171001/diff/2001/src/parser.cc File src/parser.cc (right):
http://codereview.chromium.org/6171001/diff/2001/src/parser.cc#newcode4037 src/parser.cc:4037: } On 2011/01/07 10:38:16, Erik Corry wrote:
I think it's more readable with an else and a single break.
Done. http://codereview.chromium.org/6171001/diff/2001/src/parser.cc#newcode4382 src/parser.cc:4382: // For compatability with JSC, inside a character class On 2011/01/07 10:38:16, Erik Corry wrote:
ata -> ati
Done. http://codereview.chromium.org/6171001/diff/2001/test/cctest/test-regexp.cc File test/cctest/test-regexp.cc (right): http://codereview.chromium.org/6171001/diff/2001/test/cctest/test-regexp.cc#newcode237 test/cctest/test-regexp.cc:237: CHECK_PARSE_EQ("\\c", "'\\c'"); Added to cctest/test-parsing.cc http://codereview.chromium.org/6171001/diff/2001/test/mjsunit/third_party/regexp-pcre.js File test/mjsunit/third_party/regexp-pcre.js (right): http://codereview.chromium.org/6171001/diff/2001/test/mjsunit/third_party/regexp-pcre.js#newcode4232 test/mjsunit/third_party/regexp-pcre.js:4232: // assertEquals(null, res[835].exec("a+ Z0+\x08\n\x1d\x12", 2585)); Whaddayaknow, it didn't need to be disabled at all. http://codereview.chromium.org/6171001/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev
