Thanks a lot for spotting all this stuff, Slava. And for review. Committing.

http://codereview.chromium.org/6242005/diff/1/include/v8.h
File include/v8.h (right):

http://codereview.chromium.org/6242005/diff/1/include/v8.h#newcode3391
include/v8.h:3391: ~(intptr_t(0xffffffff) << kPointerAlignment);
On 2011/01/19 10:19:43, Vyacheslav Egorov wrote:
intptr_t => uintptr_t

Done.

http://codereview.chromium.org/6242005/diff/1/include/v8.h#newcode3460
include/v8.h:3460: const uintptr_t address =
reinterpret_cast<intptr_t>(value);
On 2011/01/19 10:19:43, Vyacheslav Egorov wrote:
<intptr_t> => <uintptr_t>

Done.

http://codereview.chromium.org/6242005/diff/1/src/api.cc
File src/api.cc (right):

http://codereview.chromium.org/6242005/diff/1/src/api.cc#newcode3270
src/api.cc:3270: const uintptr_t address =
reinterpret_cast<intptr_t>(ptr);
On 2011/01/19 10:19:43, Vyacheslav Egorov wrote:
<intptr_t> => <uintptr_t>

Done.

http://codereview.chromium.org/6242005/diff/1/src/api.cc#newcode3277
src/api.cc:3277: const uintptr_t address =
reinterpret_cast<intptr_t>(ptr);
On 2011/01/19 10:19:43, Vyacheslav Egorov wrote:
<intptr_t> => <uintptr_t>

Done.

http://codereview.chromium.org/6242005/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to