First overall comment: no using directives. :) I'll have a look at the actual contents soon.
http://codereview.chromium.org/6274009/diff/1/src/arm/assembler-arm.h File src/arm/assembler-arm.h (right): http://codereview.chromium.org/6274009/diff/1/src/arm/assembler-arm.h#newcode43 src/arm/assembler-arm.h:43: #include "constants-arm.h" Can we keep the include list alphabeticed? http://codereview.chromium.org/6274009/diff/1/src/arm/assembler-arm.h#newcode47 src/arm/assembler-arm.h:47: using namespace assembler::arm; We are not using 'using' directives. Have a look at: http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Namespaces#Namespaces We can use namespace aliases and access the constants through some alias. http://codereview.chromium.org/6274009/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev
