Still LGTM.
http://codereview.chromium.org/6487021/diff/4001/src/flag-definitions.h File src/flag-definitions.h (right): http://codereview.chromium.org/6487021/diff/4001/src/flag-definitions.h#newcode235 src/flag-definitions.h:235: DEFINE_int(stack_size_kb, kPointerSize * 128, For the heap limits, the flag is something like max_new_space_size and the string help comment gives the units. You could do that here for consistency, but I don't care too much either way. http://codereview.chromium.org/6487021/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev