http://codereview.chromium.org/6531037/diff/1/src/runtime.cc File src/runtime.cc (right):
http://codereview.chromium.org/6531037/diff/1/src/runtime.cc#newcode6930 src/runtime.cc:6930: RETURN_IF_EMPTY_HANDLE(result); On 2011/02/17 20:55:41, Mads Ager wrote:
Shouldn't we be able to create a test case for this. The change looks
good, but
can we test it?
I quickly inspected the code and apparently now it's impossible to throw an exception, so I cannot imagine a regression test for it right now. Good news is I first added this check and got an expected exception and only then changes semantics of constructor property installation. Still I cannot think of a regression test for this line right now. http://codereview.chromium.org/6531037/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev
