LGTM.
http://codereview.chromium.org/6538080/diff/5001/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): http://codereview.chromium.org/6538080/diff/5001/src/hydrogen-instructions.h#newcode725 src/hydrogen-instructions.h:725: class HOperandContainer { This is essentially the same as the corresponding Lithium container. Let's consider adding to utils a generic EmbeddedContainer template class parameterized over type and length. http://codereview.chromium.org/6538080/diff/5001/src/hydrogen-instructions.h#newcode728 src/hydrogen-instructions.h:728: for (int i = 0; i < NumElements; i++) elems_[i] = NULL; We should be able to zero initialize the elems_ by naming it in the initializer list: HOperandContainer() : elems_() { } I've started using that style, so there is precedent. http://codereview.chromium.org/6538080/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
