On 2011/03/11 01:14:50, ry wrote:
On 2011/03/11 01:08:46, Vitaly Repeshko wrote:
> http://codereview.chromium.org/6674002/diff/5001/src/platform-solaris.cc
> File src/platform-solaris.cc (right):
>
>
http://codereview.chromium.org/6674002/diff/5001/src/platform-solaris.cc#newcode683
> src/platform-solaris.cc:683: pthread_kill(vm_tgid_, SIGPROF);
> On 2011/03/11 01:02:00, ry wrote:
> > On 2011/03/11 00:08:27, Vitaly Repeshko wrote:
> > > Does work with vm_tid_ here?
> >
> > Oops. With that I get crashes
>
> So if it crashes because of a stale thread handle, we have to use
something
> lower level. Please try using thr_* stuff.
the thr_kill is the same function - still get crashes. It's uncertain if
there
is a different way to do this in Solaris...
OK, let's give up for now. In the worst case we'll just get no statistical
profiling ticks (so running with --prof won't produce profiles), but the
Crankshaft infrastructure won't be affected because it doesn't depend on
signals. I'll land the first patch set with the comment updated.
-- Vitaly
http://codereview.chromium.org/6674002/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
