LGTM
http://codereview.chromium.org/6658037/diff/2001/src/v8natives.js File src/v8natives.js (right): http://codereview.chromium.org/6658037/diff/2001/src/v8natives.js#newcode255 src/v8natives.js:255: desc = ToPropertyDescriptor(desc); Why not var desc = new PropertyDescriptor(); desc.setEnumerable(true); ... etc. Or at least make it var desc = { ..., __proto__:null }; to ensure against inherited values. http://codereview.chromium.org/6658037/diff/2001/src/v8natives.js#newcode276 src/v8natives.js:276: var desc = { set: fun, enumerable: true, configurable: true }; Ditto. http://codereview.chromium.org/6658037/diff/2001/src/v8natives.js#newcode401 src/v8natives.js:401: //PropertyDescriptor.prototype.__proto__ = null; Uncomment this! :) And add: PropertyDescriptor.prototype.toString = function() { return "[object PropertyDescriptor]"; }; http://codereview.chromium.org/6658037/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
