LGTM.
Shouldn't you get rid of
movq(Register, ExternalReference), and eliminate all uses of it, or make it
protected? Your new functions should be able to replace all uses of it,
right?
http://codereview.chromium.org/6716018/diff/1/src/x64/deoptimizer-x64.cc
File src/x64/deoptimizer-x64.cc (left):
http://codereview.chromium.org/6716018/diff/1/src/x64/deoptimizer-x64.cc#oldcode760
src/x64/deoptimizer-x64.cc:760: ExternalReference roots_address =
ExternalReference::roots_address();
Could this be necessary for serialization reasons?
http://codereview.chromium.org/6716018/diff/1/src/x64/regexp-macro-assembler-x64.cc
File src/x64/regexp-macro-assembler-x64.cc (right):
http://codereview.chromium.org/6716018/diff/1/src/x64/regexp-macro-assembler-x64.cc#newcode67
src/x64/regexp-macro-assembler-x64.cc:67: * kRootRegister) are not
initialized during RegExp code.
"are not initialized" is confusing. Do you mean "free for general
purpose use during RegExp code"?
http://codereview.chromium.org/6716018/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
