http://codereview.chromium.org/6726050/diff/5001/src/platform-freebsd.cc File src/platform-freebsd.cc (right):
http://codereview.chromium.org/6726050/diff/5001/src/platform-freebsd.cc#newcode639 src/platform-freebsd.cc:639: const pthread *vm_tid() const { return vm_tid_; } I think this should return "pthread_t" (no const). http://codereview.chromium.org/6726050/diff/5001/src/platform-freebsd.cc#newcode642 src/platform-freebsd.cc:642: const pthread *vm_tid_; pthread_t http://codereview.chromium.org/6726050/diff/5001/src/platform-freebsd.cc#newcode692 src/platform-freebsd.cc:692: thread_id_(pthread_self()), Should be unused -- see below. http://codereview.chromium.org/6726050/diff/5001/src/platform-freebsd.cc#newcode783 src/platform-freebsd.cc:783: void SendProfilingSignal(const pthread *tid) { pthread_t http://codereview.chromium.org/6726050/diff/5001/src/platform-freebsd.cc#newcode785 src/platform-freebsd.cc:785: pthread_kill(thread_id_, SIGPROF); Use the thread id parameter here. http://codereview.chromium.org/6726050/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
