http://codereview.chromium.org/6756003/diff/1/src/accessors.cc File src/accessors.cc (right):
http://codereview.chromium.org/6756003/diff/1/src/accessors.cc#newcode122 src/accessors.cc:122: Isolate* isolate = Isolate::Current(); Please get the isolate from the object parameter instead of taking it through thread-local storage: object->GetIsolate(). Also, please extract it before creating the handle scope and pass it in as an argument there as well. Also pass it to the handle constructor. http://codereview.chromium.org/6756003/diff/1/src/accessors.cc#newcode320 src/accessors.cc:320: Isolate* isolate = Isolate::Current(); Please extract the isolate from the object. The object is casted to a JSValue which is a heap object from which you can get the isolate. Pass the isolate pointer to the handle scope constructor and the handle constructor. http://codereview.chromium.org/6756003/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
