Oops, I never pressed the 'm' button. Change already landed with all changes suggested.
Thanks! Martin http://codereview.chromium.org/6711063/diff/1/test/test262/harness-adapt.js File test/test262/harness-adapt.js (right): http://codereview.chromium.org/6711063/diff/1/test/test262/harness-adapt.js#newcode68 test/test262/harness-adapt.js:68: (test.precondition !== undefined) ? test.precondition.toString() : '', On 2011/03/21 10:18:30, Mads Ager wrote:
Let's get rid of the long line. :)
Done. http://codereview.chromium.org/6711063/diff/1/test/test262/jquery.js File test/test262/jquery.js (right): http://codereview.chromium.org/6711063/diff/1/test/test262/jquery.js#newcode28 test/test262/jquery.js:28: function $() {} On 2011/03/21 10:18:30, Mads Ager wrote:
This seems annoying to have to do. If we cannot get rid of jquery
dependency, we
should rename the file to jquery-mock.js or something like that.
Turns out the file wasn't needed. I needed it in the earlier version of the patch but no longer. Deleted. http://codereview.chromium.org/6711063/diff/1/test/test262/testcfg.py File test/test262/testcfg.py (right): http://codereview.chromium.org/6711063/diff/1/test/test262/testcfg.py#newcode81 test/test262/testcfg.py:81: harness += [join(self.root, 'data', 'test', 'harness', f) for f in TEST_262_HARNESS] On 2011/03/21 10:23:53, Rico wrote:
Long line
Done. http://codereview.chromium.org/6711063/diff/1/test/test262/testcfg.py#newcode101 test/test262/testcfg.py:101: harness += [join(self.root, 'data', 'test', 'harness', f) for f in TEST_262_HARNESS] On 2011/03/21 10:23:53, Rico wrote:
Long line
Done. http://codereview.chromium.org/6711063/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
