LGTM
http://codereview.chromium.org/6749029/diff/1/src/preparser-api.cc File src/preparser-api.cc (right): http://codereview.chromium.org/6749029/diff/1/src/preparser-api.cc#newcode163 src/preparser-api.cc:163: : JavaScriptScanner(&scanner_constants_), scanner_constants_() { } This passes a pointer to a not yet initialized object. Maybe heap allocate it for safety? http://codereview.chromium.org/6749029/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev