http://codereview.chromium.org/6839015/diff/1/src/hydrogen.cc File src/hydrogen.cc (right):
http://codereview.chromium.org/6839015/diff/1/src/hydrogen.cc#newcode2277 src/hydrogen.cc:2277: if (scope->function() != NULL) return Bailout("named function expression"); On 2011/04/13 12:00:43, danno wrote:
I didn't know this actually works, returning the result of a void
function call.
Is this something done elsewhere in the code?
I'm not sure if it's done elsewhere, I can't think of a place (except a few I fixed because they were accidental). Here it seems fairly "principled". If it makes you squeamish, compare it to the macro :-) http://codereview.chromium.org/6839015/diff/1/src/hydrogen.cc#newcode2808 src/hydrogen.cc:2808: ASSERT(!HasStackOverflow()); On 2011/04/13 12:00:43, danno wrote:
Turn these three checks into a single check, like
ASSERT(HasNotBailedOut())? OK, I'll do that. http://codereview.chromium.org/6839015/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
