LGTM
http://codereview.chromium.org/7077004/diff/3001/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/7077004/diff/3001/src/runtime.cc#newcode3538 src/runtime.cc:3538: ASSERT(2 <= radix && radix <= 36); ASSERT -> RUNTIME_ASSERT http://codereview.chromium.org/7077004/diff/3001/src/runtime.cc#newcode3548 src/runtime.cc:3548: } Maybe we should have special case for < radix^2 too, for cached two-byte strings. http://codereview.chromium.org/7077004/diff/3001/src/runtime.cc#newcode5102 src/runtime.cc:5102: SinkChar* write_cursor, indentation. http://codereview.chromium.org/7077004/diff/3001/src/runtime.cc#newcode5241 src/runtime.cc:5241: } I dare you to put an AssertNoAllocation no_gc; here. http://codereview.chromium.org/7077004/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
