I think using regexp is fine for this. If the frontend wants a simpler
pattern
it can just convert it to a regexp.
You should add some tests and extend d8 to support it for debugging.
How about also adding break points of type sourceRegexp where a regexp
match in
the actual source inserts a breakpoint? That might be useful for breaking in
code from eval.
http://codereview.chromium.org/7091001/diff/1/src/debug-debugger.js
File src/debug-debugger.js (right):
http://codereview.chromium.org/7091001/diff/1/src/debug-debugger.js#newcode72
src/debug-debugger.js:72: ScriptRegexp: 2 };
I guess that we do need an additional type here even thought he name
matching could be a regexp as well.
http://codereview.chromium.org/7091001/diff/1/src/debug-debugger.js#newcode1624
src/debug-debugger.js:1624: } else if (type == 'scriptRegexp') {
Can't we combine 'script' and 'scriptRegexp' here, and convert the name
matching to a regexp?
http://codereview.chromium.org/7091001/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
