LGTM
http://codereview.chromium.org/7122003/diff/1/src/x64/full-codegen-x64.cc File src/x64/full-codegen-x64.cc (right): http://codereview.chromium.org/7122003/diff/1/src/x64/full-codegen-x64.cc#newcode197 src/x64/full-codegen-x64.cc:197: // Update the write barrier. This clobbers rax and rbx. rogue space before This http://codereview.chromium.org/7122003/diff/1/src/x64/full-codegen-x64.cc#newcode3151 src/x64/full-codegen-x64.cc:3151: __ movq(object, elements); Is this still required? http://codereview.chromium.org/7122003/diff/1/src/x64/full-codegen-x64.cc#newcode3152 src/x64/full-codegen-x64.cc:3152: __ RememberedSetHelper( I think ia32 has a comment that explains why we don't need to inform incremental marker here. http://codereview.chromium.org/7122003/diff/1/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): http://codereview.chromium.org/7122003/diff/1/src/x64/lithium-codegen-x64.cc#newcode2237 src/x64/lithium-codegen-x64.cc:2237: } Missing WriteBarrier (just for the record). http://codereview.chromium.org/7122003/diff/1/src/x64/macro-assembler-x64.cc File src/x64/macro-assembler-x64.cc (right): http://codereview.chromium.org/7122003/diff/1/src/x64/macro-assembler-x64.cc#newcode344 src/x64/macro-assembler-x64.cc:344: FLAG_incremental_marking == false) { == false is just too strange if we have the same in ia32 we should fix it. http://codereview.chromium.org/7122003/diff/1/src/x64/macro-assembler-x64.cc#newcode3741 src/x64/macro-assembler-x64.cc:3741: bool Aliasing(Register r1, Register r2, Register r3, Register r4) { Aliasing is a very strange name. http://codereview.chromium.org/7122003/diff/1/src/x64/macro-assembler-x64.cc#newcode3793 src/x64/macro-assembler-x64.cc:3793: j(cc, condition_met, condition_met_near); why conditions_met_near is called *_near not *_distance? http://codereview.chromium.org/7122003/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
