LGTM
though I am bit concerned about using value of an internal type in the
structure
from the public header.
http://codereview.chromium.org/6982059/diff/4/include/v8.h
File include/v8.h (right):
http://codereview.chromium.org/6982059/diff/4/include/v8.h#newcode3262
include/v8.h:3262: v8::internal::Isolate* isolate_;
I think it's the first time when we actually use value of type
v8::internal::Isolate* in the v8.h.
Maybe we should use void* instead?
http://codereview.chromium.org/6982059/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
