LGTM, with some small comments below.
http://codereview.chromium.org/7024047/diff/8001/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/7024047/diff/8001/src/arm/code-stubs-arm.cc#newcode3975 src/arm/code-stubs-arm.cc:3975: // r1 = parameter count (untagged) Still says untagged in the change set. http://codereview.chromium.org/7024047/diff/8001/src/arm/code-stubs-arm.cc#newcode4004 src/arm/code-stubs-arm.cc:4004: __ mov(r9, r1); Not a big deal, but you could save the mov(r1, r9) below by using (and destroying) r9 instead of r1. http://codereview.chromium.org/7024047/diff/8001/src/arm/code-stubs-arm.cc#newcode4036 src/arm/code-stubs-arm.cc:4036: __ cmp(r1, Operand(0)); Operand(Smi::FromInt(0))? http://codereview.chromium.org/7024047/diff/8001/src/x64/code-stubs-x64.cc File src/x64/code-stubs-x64.cc (right): http://codereview.chromium.org/7024047/diff/8001/src/x64/code-stubs-x64.cc#newcode2006 src/x64/code-stubs-x64.cc:2006: __ push(rbx); I don't know what the register story on x64 is (Bill or Lasse would know). I think there are available registers to avoid this push. http://codereview.chromium.org/7024047/diff/8001/src/x64/code-stubs-x64.cc#newcode2091 src/x64/code-stubs-x64.cc:2091: __ push(rax); May be able to avoid this push. http://codereview.chromium.org/7024047/diff/8001/src/x64/code-stubs-x64.cc#newcode2116 src/x64/code-stubs-x64.cc:2116: __ push(rcx); Also here. http://codereview.chromium.org/7024047/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
