LGTM
However there are some things you need to consider.
I don't know how you plan to use the shell on the host, but we are planning
to
shave down the shell to a bare minimum sample application and going forward
use
the developer shell (d8) as the V8 shell.
We have a GYP file for building d8 in src/d8.gyp, so maybe you should
consider
that instead.
Also there is a separate GYP for the sample shell in samples/samples.gyp so
we
should also consider removing the v8_shell target from this file to avoid
duplication.
http://codereview.chromium.org/7212014/diff/1/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):
http://codereview.chromium.org/7212014/diff/1/tools/gyp/v8.gyp#newcode959
tools/gyp/v8.gyp:959: 'toolsets': ['host'],
Shouldn't we build v8_shell for the target while we are at it?
http://codereview.chromium.org/7212014/diff/1/tools/gyp/v8.gyp#newcode993
tools/gyp/v8.gyp:993: 'toolsets': ['host'],
Ditto.
http://codereview.chromium.org/7212014/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
