thanks, landed!
http://codereview.chromium.org/7189066/diff/1/src/heap.cc File src/heap.cc (right): http://codereview.chromium.org/7189066/diff/1/src/heap.cc#newcode5456 src/heap.cc:5456: On 2011/06/20 20:41:26, Erik Corry wrote:
missing blank line
Done. http://codereview.chromium.org/7189066/diff/1/src/heap.cc#newcode5520 src/heap.cc:5520: // ASSERT_TAG_ALIGNED(map_addr); On 2011/06/20 20:41:26, Erik Corry wrote:
commented code
Done. http://codereview.chromium.org/7189066/diff/1/src/mark-compact-inl.h File src/mark-compact-inl.h (right): http://codereview.chromium.org/7189066/diff/1/src/mark-compact-inl.h#newcode61 src/mark-compact-inl.h:61: On 2011/06/20 20:41:26, Erik Corry wrote:
missing blank line
Done. http://codereview.chromium.org/7189066/diff/1/src/mark-compact.cc File src/mark-compact.cc (right): http://codereview.chromium.org/7189066/diff/1/src/mark-compact.cc#newcode195 src/mark-compact.cc:195: // TODO(gc): XXX On 2011/06/20 20:41:26, Erik Corry wrote:
Add text or remove XXX
Done. http://codereview.chromium.org/7189066/diff/1/src/mark-compact.cc#newcode248 src/mark-compact.cc:248: // Null out the GC tracer. On 2011/06/20 20:41:26, Erik Corry wrote:
Comment doesnt really add much. Why are we nulling it out?
Cause it's stack allocated. http://codereview.chromium.org/7189066/diff/1/src/mark-compact.cc#newcode727 src/mark-compact.cc:727: MarkObjectByPointer(heap, reinterpret_cast<Address>(start), p); On 2011/06/20 20:41:26, Erik Corry wrote:
Seems like everywhere you call this you are casting the anchor from an
Object**
to an Address. Perhaps it should just be an Object**.
Done. http://codereview.chromium.org/7189066/diff/1/src/mark-compact.cc#newcode1350 src/mark-compact.cc:1350: /* On 2011/06/20 20:41:26, Erik Corry wrote:
commented code
Done. http://codereview.chromium.org/7189066/diff/1/src/mark-compact.cc#newcode2073 src/mark-compact.cc:2073: remaining--) { On 2011/06/20 20:41:26, Erik Corry wrote:
Fits on one line.
Done. http://codereview.chromium.org/7189066/diff/1/src/mark-compact.h File src/mark-compact.h (right): http://codereview.chromium.org/7189066/diff/1/src/mark-compact.h#newcode270 src/mark-compact.h:270: private: On 2011/06/20 20:41:26, Erik Corry wrote:
missing blank line before private:
Done. http://codereview.chromium.org/7189066/diff/1/src/store-buffer.cc File src/store-buffer.cc (right): http://codereview.chromium.org/7189066/diff/1/src/store-buffer.cc#newcode586 src/store-buffer.cc:586: On 2011/06/20 20:41:26, Erik Corry wrote:
Spurious blank line.
Done. http://codereview.chromium.org/7189066/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
