Certainly-- it just will need a little more infrastructure! OK, I'll pull down this changelist and get working on something that looks closer to what you've described below.
On Thu, Jul 7, 2011 at 4:52 PM, Vyacheslav Egorov <[email protected]>wrote: > Hi Luke, > > Well. No, I meant something different. I wanted to merge them > completely. e.g. be able to write something like: > > js_function_ = DefineAbbreviation(WITH_CHILDREN); > js_function_.Attribute(DW_AT_NAME, DWARFString(name)); > js_function_.Attribute(DW_AT_LOW_PC, DWARFAddr(desc_->CodeStart())); > js_function_.Attribute(DW_AT_HIGH_PC, DWARFAddr(desc_->CodeStart() + > desc_->CodeSize())); > js_function_.Attribute(DW_AT_FRAME_BASE, DWARFBlock4(...)); > dwarf_sections_.Add(js_function_); > > basically this should provide unified way to emit both section if possible. > > Seems possible (and way more elegant than what we have currently). > What do you think? > > -- > Vyacheslav Egorov > > > On Fri, Jul 8, 2011 at 1:42 AM, <[email protected]> wrote: > > Reviewers: Vyacheslav Egorov, > > > > Message: > > Please take a look at this CL if you get a chance! Is this somewhat > similar > > to > > what you had in mind wrt merging DebugInfo with DebugAbbrevs, or were you > > thinking of a different tactic? > > > > Description: > > [gdb-jit] Merge DWARF abbreviation generation with use. > > > > This patch stops gdb-jit support from generating redundant abbreviations, > > better abstracts the mapping between abbreviation IDs and the DWARF data > > they > > represent, and generates only those abbreviations that are used. > > > > BUG= > > TEST= > > > > > > Please review this at http://codereview.chromium.org/7327012/ > > > > SVN Base: git://github.com/v8/v8.git@master > > > > Affected files: > > M src/gdb-jit.cc > > > > > > > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
