LGTM apart from the small readability issue.
http://codereview.chromium.org/7307035/diff/1/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/7307035/diff/1/src/runtime.cc#newcode10069 src/runtime.cc:10069: } This is a bit hard to read, perhaps: bool inlined_frame = it.frame()->is_optimized() && deoptimized_frame_index != 0; bool constructor = !inlined_frame && it.frame()->IsConstructor(); http://www.refactoring.com/catalog/introduceExplainingVariable.html ;-) Or even better: Can this be moved into IsConstructor? It's a bit hard for me to judge from its uses. http://codereview.chromium.org/7307035/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
