On Sun, Jul 17, 2011 at 1:59 AM, <[email protected]> wrote: > LGTM, I'll land it. >
Thanks Mads! We'll take care of the WebKit piece once v8 rolls on trunk. > > http://codereview.chromium.**org/7395012/diff/10/include/**v8.h<http://codereview.chromium.org/7395012/diff/10/include/v8.h> > File include/v8.h (right): > > http://codereview.chromium.**org/7395012/diff/10/include/** > v8.h#newcode2807<http://codereview.chromium.org/7395012/diff/10/include/v8.h#newcode2807> > include/v8.h:2807: * of cryptographically safe entropy. > Let's remove the "cryptographically safe" part of this comment. There is > no requirement on the entropy source. Whether or not it is > cryptographically safe is up to the user of the API to decide. > > http://codereview.chromium.**org/7395012/diff/10/src/v8.h<http://codereview.chromium.org/7395012/diff/10/src/v8.h> > File src/v8.h (right): > > http://codereview.chromium.**org/7395012/diff/10/src/v8.h#**newcode94<http://codereview.chromium.org/7395012/diff/10/src/v8.h#newcode94> > src/v8.h:94: // Allows a cryptographically safe entropy source to be > provided > Let's remove the cryptographically safe part. > > > http://codereview.chromium.**org/7395012/<http://codereview.chromium.org/7395012/> > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
