LGTM
Lots of comments on the ChangeLog. Most (or all) can be ignored if you feel
this
level of detail is better.
http://codereview.chromium.org/7397010/diff/1/ChangeLog
File ChangeLog (right):
http://codereview.chromium.org/7397010/diff/1/ChangeLog#newcode1
ChangeLog:1: 2011-07-18: Version 3.4.13
I would leave out most of this. I would only put stuff useful to
embedders here. I would have:
- Debugger, optimized frames
- API for wrapped primitive values
- API for entropy source
Those are the things that are mainly useful for embedders. For normal
bug fixes, the first push after the fix will contain the fix and we
usually do not spend time putting it in the ChangeLog.
I can see that the ChangeLog has become more verbose lately, so feel
free to ignore. I have considered multiple times if we should just get
rid of the ChangeLog. I wonder if anyone actually uses it.
http://codereview.chromium.org/7397010/diff/1/ChangeLog#newcode3
ChangeLog:3: Support scope information and evaluation in optimized
frames (issue
Maybe write that this is improved debugger support to allow inspection
of optimized frames?
http://codereview.chromium.org/7397010/diff/1/ChangeLog#newcode8
ChangeLog:8: Implemented ICs for FastDoubleArray loads and stores for
ia32, x64 and
This is not turned on by default, so I would leave out this line.
http://codereview.chromium.org/7397010/diff/1/ChangeLog#newcode17
ChangeLog:17: Exposed APIs for detecting boxed primitives, native errors
and Math.
The Math part did not land and is handled differently.
http://codereview.chromium.org/7397010/diff/1/ChangeLog#newcode26
ChangeLog:26: Implemented delete trap for proxies (issue 1543).
Not on by default, so I would delete this line.
http://codereview.chromium.org/7397010/diff/1/ChangeLog#newcode33
ChangeLog:33: initialization. (chrome issue 89462).
chrome -> chromium.
http://codereview.chromium.org/7397010/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
