http://codereview.chromium.org/7386003/diff/1003/src/mips/stub-cache-mips.cc File src/mips/stub-cache-mips.cc (right):
http://codereview.chromium.org/7386003/diff/1003/src/mips/stub-cache-mips.cc#newcode4372 src/mips/stub-cache-mips.cc:4372: // -- a3 : scratch On 2011/07/18 14:36:12, danno wrote:
This comment is out of date with the renames of the register names
below. It's
also wrong in ARM, I'll fix it.
I updated the comment for the named scratch regs. However, this opens up potential for more register "state" comment updates throughout this file. This function uses a couple FPU registers as scratch, which are not commented (as arm uses uncommented VFP scratch regs). Many other functions declare input regs but do not declare scratch regs, whether named or un-named. Examples: GenerateLoadFastElement(), GenerateLoadFastDoubleElement(), GenerateStoreExternalArray(), many others. It is probably a good idea to comment these, but I've not done so here. We will follow your lead on this. http://codereview.chromium.org/7386003/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
