Feedback addressed, please take another quick look, since there were a few
minor
additional tweaks to get rid of all the problems.
I'll see if there is an easy way to add a regression test in a separate CL.
http://codereview.chromium.org/7497010/diff/2001/src/heap.cc
File src/heap.cc (right):
http://codereview.chromium.org/7497010/diff/2001/src/heap.cc#newcode3400
src/heap.cc:3400: maybe_elem =
On 2011/07/27 08:05:51, Rico wrote:
Fits on one line
Done.
http://codereview.chromium.org/7497010/diff/2001/src/heap.cc#newcode3770
src/heap.cc:3770: { MaybeObject* maybe_obj =
AllocateRawFixedDoubleArray(len,
On 2011/07/27 08:05:51, Rico wrote:
Fits on one line
Done.
http://codereview.chromium.org/7497010/diff/2001/src/heap.cc#newcode3776
src/heap.cc:3776: CopyBlock(dst->address() + kPointerSize,
On 2011/07/27 08:05:51, Rico wrote:
Would it not be more correct to use FixedDoubleArray::kLengthOffset or
HeapObject::kHeaderSize, instead of just adding kPointerSize here
Done.
http://codereview.chromium.org/7497010/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
