There can be other reasons for being interrupted, e.g., preemption by another thread that causes a GC. Anything that causes Code to move should trigger this.
/L On Fri, Aug 26, 2011 at 18:12, Yang Guo <yang...@chromium.org> wrote: > Isn't the issue that, as far as I can see, this part of code is only called > when the we switch to the profiler thread in the middle of regexp code and > in there trigger GC? If crankshaft is disabled, profiler doesn't run and the > regexp code won't be interrupted and we won't jump into this part of code in > the first place. > -- Yang > > On Fri, Aug 26, 2011 at 5:43 PM, <l...@chromium.org> wrote: >> >> LGTM. >> You shouldn't need crankshaft, just a compacting GC that moves the calling >> Code >> object. I'm not sure there is a good way to do that consistently, though. >> >> http://codereview.chromium.org/7741041/ > > -- Lasse R.H. Nielsen l...@google.com 'Faith without judgement merely degrades the spirit divine' Google Denmark ApS - Frederiksborggade 20B, 1 sal - 1360 København K - Denmark - CVR nr. 28 86 69 84 -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev
