Reviewers: Lasse Reichstein,
Message:
Lasse, if everything is ok, could you land this to me?
PS: Please, keep the Signed-off line.
Copying Mikhail, as he already committed some patches for me.
Thanks!
http://codereview.chromium.org/7835019/diff/1/src/scanner.h
File src/scanner.h (right):
http://codereview.chromium.org/7835019/diff/1/src/scanner.h#newcode29
src/scanner.h:29: #define V8_SCANNER_H_
Is it worth renaming this file to something more closer to the classes
it holds now?
http://codereview.chromium.org/7835019/diff/1/src/scanner.h#newcode31
src/scanner.h:31: #include "scanner-base.h"
This include is only needed to get UC16CharacterStream.
Description:
Remove unused includes from scanner.h.
This file should also be renamed to something else, as after many refactors,
there isn't any Scanner class in there, just four CharacterStream classes.
[email protected]
Signed-off-by: Thiago Farina <[email protected]>
Please review this at http://codereview.chromium.org/7835019/
SVN Base: git://github.com/v8/v8.git@master
Affected files:
M src/parser.cc
M src/scanner.h
M test/cctest/test-regexp.cc
Index: src/parser.cc
diff --git a/src/parser.cc b/src/parser.cc
index
a863165b015ac78d883a88f5ffc5bfab5e727e51..30d6f222de3dfd8fc2c88755558ba880f7d59d3d
100644
--- a/src/parser.cc
+++ b/src/parser.cc
@@ -30,6 +30,7 @@
#include "api.h"
#include "ast-inl.h"
#include "bootstrapper.h"
+#include "char-predicates-inl.h"
#include "codegen.h"
#include "compiler.h"
#include "func-name-inferrer.h"
Index: src/scanner.h
diff --git a/src/scanner.h b/src/scanner.h
index
e66dd60d84a16b3d776fde605e4ecac1a57561a1..6422ee8cab8ab71868b47f504d37e89fb3a47a4d
100644
--- a/src/scanner.h
+++ b/src/scanner.h
@@ -28,8 +28,6 @@
#ifndef V8_SCANNER_H_
#define V8_SCANNER_H_
-#include "token.h"
-#include "char-predicates-inl.h"
#include "scanner-base.h"
namespace v8 {
Index: test/cctest/test-regexp.cc
diff --git a/test/cctest/test-regexp.cc b/test/cctest/test-regexp.cc
index
9f18b600b25162e028f9d7da319344528e58acd4..46ac88cd9241e5a5d48d457bb4ed5a291f50b1e4
100644
--- a/test/cctest/test-regexp.cc
+++ b/test/cctest/test-regexp.cc
@@ -30,14 +30,15 @@
#include "v8.h"
-#include "string-stream.h"
-#include "cctest.h"
-#include "zone-inl.h"
-#include "parser.h"
#include "ast.h"
+#include "char-predicates-inl.h"
+#include "cctest.h"
#include "jsregexp.h"
+#include "parser.h"
#include "regexp-macro-assembler.h"
#include "regexp-macro-assembler-irregexp.h"
+#include "string-stream.h"
+#include "zone-inl.h"
#ifdef V8_INTERPRETED_REGEXP
#include "interpreter-irregexp.h"
#else // V8_INTERPRETED_REGEXP
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
