Reviewers: Erik Corry,
Message:
PTAL.
Description:
Fix bogus reset of store buffer top in deserializer.
This was originally introduced in r6201 because the store buffer top is
part of the root set and treated as SMI, which in turn causes it to be
overwritten by the deserializer. A better fix was introduced in r6443
and skips the entry instead of restoring it after deserialization, thus
making this reset obsolete.
[email protected]
BUG=v8:1562
Please review this at http://codereview.chromium.org/7858035/
SVN Base: https://v8.googlecode.com/svn/branches/experimental/gc
Affected files:
M src/serialize.cc
Index: src/serialize.cc
diff --git a/src/serialize.cc b/src/serialize.cc
index
c228b5a8b368b5b85b18997bb14983fbbf2b7a45..a3d3d7ba08e1d759975b6075d3e2e96d20608b96
100644
--- a/src/serialize.cc
+++ b/src/serialize.cc
@@ -650,8 +650,6 @@ void Deserializer::Deserialize() {
isolate_ = Isolate::Current();
ASSERT(isolate_ != NULL);
// Don't GC while deserializing - just expand the heap.
- Address* store_buffer_top =
- reinterpret_cast<Address*>(isolate_->heap()->store_buffer_top());
AlwaysAllocateScope always_allocate;
// Don't use the free lists while deserializing.
LinearAllocationScope allocate_linearly;
@@ -670,7 +668,6 @@ void Deserializer::Deserialize() {
isolate_->heap()->set_global_contexts_list(
isolate_->heap()->undefined_value());
- isolate_->heap()->public_set_store_buffer_top(store_buffer_top);
}
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
