> Nested ternary operators are hard to read and this is a bit long for an
> initialization list. how about just doing the strlen() bit in the
constructor
> body.

You're right; it works great as-is but it's fragile enough [snip]

I remembered why this is the way it is. The ExternalStringResourceBase class has made the assignment operator private, which means that I must initialize source_
in the initialization list. I'm open to other readability improvements, but
unless you know a trick in C++ that I don't (entirely possible), I think we're
stuck as long as assignment is disabled.

http://codereview.chromium.org/7889046/

--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev

Reply via email to