lgtm
http://codereview.chromium.org/8245007/diff/1/src/mark-compact.cc File src/mark-compact.cc (right): http://codereview.chromium.org/8245007/diff/1/src/mark-compact.cc#newcode3762 src/mark-compact.cc:3762: void MarkCompactCollector::RecordEmbeddedSlot(RelocInfo* rinfo, Why not unify with RecordRelocSlot? seems almost identical. http://codereview.chromium.org/8245007/diff/1/src/mark-compact.h File src/mark-compact.h (right): http://codereview.chromium.org/8245007/diff/1/src/mark-compact.h#newcode323 src/mark-compact.h:323: EMBEDDED_OBJECT_SLOT, micro opt idea: consider placing it first (or in the middle) depending on the way switch over slot types is compiled in visit function (rationale: there are currently much more EMBEDDED_OBJECT_SLOTs than anything else) http://codereview.chromium.org/8245007/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
