Reviewers: danno,
Message:
Took me a loooong time to come up with this nifty fix. Please take a
thorough
look.
Description:
Change type=settings to type=none for gyp targets
TEST=Compiling Chromium with -Duse_system_v8 no longer prints a GYP warning
about "invalid type 'settings'".
Please review this at http://codereview.chromium.org/8256008/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M tools/gyp/v8.gyp
Index: tools/gyp/v8.gyp
diff --git a/tools/gyp/v8.gyp b/tools/gyp/v8.gyp
index
f53b0e77c1827a09e1eb327829a34cb961f37aa8..4812930072f54461cf12f0c194a5df7d4da8c5ed
100644
--- a/tools/gyp/v8.gyp
+++ b/tools/gyp/v8.gyp
@@ -870,7 +870,7 @@
'targets': [
{
'target_name': 'v8',
- 'type': 'settings',
+ 'type': 'none',
'conditions': [
['want_separate_host_toolset==1', {
'toolsets': ['host', 'target'],
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
