I like the direction. I do not have any comments except some nits.
http://codereview.chromium.org/8357010/diff/1/src/ic.cc File src/ic.cc (right): http://codereview.chromium.org/8357010/diff/1/src/ic.cc#newcode1897 src/ic.cc:1897: add empty line http://codereview.chromium.org/8357010/diff/1/src/stub-cache.cc File src/stub-cache.cc (right): http://codereview.chromium.org/8357010/diff/1/src/stub-cache.cc#newcode935 src/stub-cache.cc:935: return reinterpret_cast<Code*>(code); I wonder how this can be callled during marking phase. Also marking phase does not corrupt maps anymore so we should convert to checked casts here. http://codereview.chromium.org/8357010/diff/1/src/stub-cache.cc#newcode1056 src/stub-cache.cc:1056: MaybeObject* StubCache::TryComputeCallMiss(int argc, I wonder why ComputeCallMiss is not defined in terms on TryComputeCallMiss? Are we going to kill TryComputeCallMiss once the stub compiler is fully handlified? If so please state this in the comments. http://codereview.chromium.org/8357010/diff/1/src/stub-cache.h File src/stub-cache.h (right): http://codereview.chromium.org/8357010/diff/1/src/stub-cache.h#newcode800 src/stub-cache.h:800: MUST_USE_RESULT MaybeObject* CompileCallField(JSObject* object, Should not we prefix unhandlified functions' names with Try? http://codereview.chromium.org/8357010/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
