LGTM if comments address non-issues.
http://codereview.chromium.org/8344082/diff/1/src/compiler.cc File src/compiler.cc (right): http://codereview.chromium.org/8344082/diff/1/src/compiler.cc#newcode602 src/compiler.cc:602: shared->set_strict_mode_flag(strict_mode); This is not quite equivalent, I guess. The old version only sets if in strict mode, the new version sets in any case. Also, any performance implications? http://codereview.chromium.org/8344082/diff/1/src/parser.cc File src/parser.cc (right): http://codereview.chromium.org/8344082/diff/1/src/parser.cc#newcode655 src/parser.cc:655: top_scope_->SetStrictModeFlag(strict_mode); Here again. This only works if you assume the previous state to be not in strict mode. http://codereview.chromium.org/8344082/diff/1/src/parser.cc#newcode742 src/parser.cc:742: scope->SetStrictModeFlag(shared_info->strict_mode_flag()); Ditto. http://codereview.chromium.org/8344082/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
