I made that change in my static frame alignment stuff, and it is relatively easy - the code for calling with an adaptor is already there, in case too many arguments have been provided, and so you just change the generated test to always generate the adaptor, and handle the too-few arguments case.
On Fri, Oct 21, 2011 at 11:23 AM, <[email protected]> wrote: > OK, but it's impossible to know it's actually correct at all sites. Let us > put > it in to fix the issue, but I have an idea: > > The caller-drop function has been a problem for various reasons. I wonder > if it > would be simpler to change the CallFunction stub to (a) call, not tail call, > the > function (so the stub has to have its own frame) and (b) act as an adaptor > to > drop the extra argument. > > We could have another version of the stub for Crankshaft that just took the > function in edi with no need to drop it or emit it in PushArgument to push > it > out to the stub. > > http://codereview.chromium.org/8360001/ > > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > -- William Hesse Software Engineer [email protected] Google Denmark ApS Frederiksborggade 20B, 1 sal 1360 København K Denmark CVR nr. 28 86 69 84 If you received this communication by mistake, please don't forward it to anyone else (it may contain confidential or privileged information), please erase all copies of it, including all attachments, and please let the sender know it went to the wrong person. Thanks. -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
