http://codereview.chromium.org/8390004/diff/1/src/api.cc File src/api.cc (right):
http://codereview.chromium.org/8390004/diff/1/src/api.cc#newcode3729 src/api.cc:3729: if (str->IsAsciiRepresentation()) { On 2011/10/25 16:21:45, Yang wrote:
Same thing as WriteUtf8. WriteToFlat is faster than
InputBuffer/ReadBlock
because in case of a convoluted cons string, ReadBlock has to hunt
down the
right part to read from after every 1024 characters (buffer size).
This doesn't do the same with embedded nulls as the previous WriteAscii code. That makes me think that our test coverage of WriteAscii is not good enough. The treatment of embedded null characters is pretty bogus though, which makes me wonder if anyone uses this function. http://codereview.chromium.org/8390004/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
