LGTM.
http://codereview.chromium.org/8375053/diff/1/src/arm/stub-cache-arm.cc File src/arm/stub-cache-arm.cc (right): http://codereview.chromium.org/8375053/diff/1/src/arm/stub-cache-arm.cc#newcode3372 src/arm/stub-cache-arm.cc:3372: __ DispatchMap(r1, This probably fits all on one line, if you like that sort of thing. http://codereview.chromium.org/8375053/diff/1/src/arm/stub-cache-arm.cc#newcode3382 src/arm/stub-cache-arm.cc:3382: return GetCode(NORMAL, factory()->empty_string()); I think this is OK (changing from NULL String* to a handle to the empty string) because the name is used for logging and disassembly. http://codereview.chromium.org/8375053/diff/1/src/ia32/stub-cache-ia32.cc File src/ia32/stub-cache-ia32.cc (right): http://codereview.chromium.org/8375053/diff/1/src/ia32/stub-cache-ia32.cc#newcode3409 src/ia32/stub-cache-ia32.cc:3409: __ DispatchMap(edx, Again, fits on one line. http://codereview.chromium.org/8375053/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
