LGTM!
http://codereview.chromium.org/8341021/diff/2002/src/messages.js File src/messages.js (right): http://codereview.chromium.org/8341021/diff/2002/src/messages.js#newcode1165 src/messages.js:1165: message = IS_UNDEFINED(message) ? "" : TO_STRING_INLINE(message); Nano-optimization (i.e., feel free to ignore), but if message is undefined, you can return name directly. It's probably better to just follow the spec algorithm layout. http://codereview.chromium.org/8341021/diff/2002/test/mjsunit/error-tostring.js File test/mjsunit/error-tostring.js (right): http://codereview.chromium.org/8341021/diff/2002/test/mjsunit/error-tostring.js#newcode29 test/mjsunit/error-tostring.js:29: // Test default String representation of an Error object. Lower case "string", otherwise it seems like it's an object. http://codereview.chromium.org/8341021/diff/2002/test/mjsunit/error-tostring.js#newcode56 test/mjsunit/error-tostring.js:56: // on a given Error object. Verify the produced String representation. Lower case "string" here too. http://codereview.chromium.org/8341021/diff/2002/test/mjsunit/error-tostring.js#newcode85 test/mjsunit/error-tostring.js:85: assertEquals(["e1: e2",[1,2,3,4]], testErrorToString("e1", "e2")); Good stuff! http://codereview.chromium.org/8341021/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
