LGTM

http://codereview.chromium.org/8638012/diff/1/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):

http://codereview.chromium.org/8638012/diff/1/src/arm/code-stubs-arm.cc#newcode362
src/arm/code-stubs-arm.cc:362: __ cmp(r3, ip);
Seems like you could use CompareRoot here.

http://codereview.chromium.org/8638012/diff/1/src/arm/code-stubs-arm.cc#newcode366
src/arm/code-stubs-arm.cc:366: // statically determine the instance
size.
As discussed offline this can be omitted for MOAR speed in the next CL.

http://codereview.chromium.org/8638012/

--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev

Reply via email to