Reviewers: danno,
Message:
I can't think of a really good reason to put static functions in headers
(and I
can think of a bad reason).
Description:
Remove the static qualifier from functions in header files.
This shaves 416+ KB, just under 1% off the size of the debug d8 executable
on Linux (mostly because the CheckHelper functions for assertions were
getting separate copies for each compilation unit). The difference in
release builds is negligible---a size reduction of 0.1%.
Also, change namespace-level 'static const' variables to remove the static
storage class as it's the default. In the case of const references make
them also non-static as it probably wasn't what was intended.
R=da...@chromium.org
BUG=
TEST=
Please review this at http://codereview.chromium.org/8680013/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M include/v8.h
M src/allocation.h
M src/api.h
M src/arm/assembler-arm.h
M src/arm/assembler-arm.cc
M src/arm/constants-arm.h
M src/arm/frames-arm.h
M src/arm/macro-assembler-arm.h
M src/assembler.h
M src/bytecodes-irregexp.h
M src/char-predicates-inl.h
M src/checks.h
M src/conversions-inl.h
M src/conversions.h
M src/double.h
M src/dtoa.h
M src/fast-dtoa.h
M src/globals.h
M src/hydrogen-instructions.h
M src/ia32/frames-ia32.h
M src/ia32/macro-assembler-ia32.h
M src/mips/assembler-mips.h
M src/mips/assembler-mips.cc
M src/mips/constants-mips.h
M src/mips/frames-mips.h
M src/mips/macro-assembler-mips.h
M src/objects.h
M src/string-search.h
M src/unicode.h
M src/utils.h
M src/v8conversions.h
M src/v8globals.h
M src/v8utils.h
M src/x64/assembler-x64.h
M src/x64/frames-x64.h
M src/x64/macro-assembler-x64.h
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
